Forward compatibility with react/promise 3#20
Merged
clue merged 1 commit intoreactphp:masterfrom Mar 9, 2022
Merged
Conversation
4d4f31c to
ec2d719
Compare
Member
|
@WyriHaximus Good initiative and would love to see this getting some traction again! What are your plans for this PR? It looks like this is currently the only PR that prevents the Socket component from also supporting Promise v3 (reactphp/socket#214). |
Member
Author
|
@clue Will update it tonight 👍 |
Member
Author
|
@clue It also depends on reactphp/promise-timer#54 to be tagged, but I've addressed the last two failures in this PR and pushed it in mergable state. |
clue
reviewed
Mar 7, 2022
clue
reviewed
Mar 8, 2022
clue
approved these changes
Mar 9, 2022
Member
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
This was referenced Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.