Support PHP 8, update to reactphp/socket v1.6 and adjust type checks for invalid chunk headers#391
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Aug 31, 2020
Merged
Conversation
jsor
approved these changes
Aug 31, 2020
WyriHaximus
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds supports for PHP 8. 🎉
Update to reactphp/socket v1.6 (support PHP 8), specifically reactphp/socket#246. Additionally,
dechex()throws a type error as of PHP 8 beta 2 (https://3v4l.org/RHg0i) that can be exhibited when trying to verify excessive chunk headers that exceed integer bounds. This is similar to #357 which adjusted this for PHP 7.4 recently.This means this component now supports PHP 8 just fine 🎉
This currently reports a bunch of warnings due to some deprecations introduced in PHPUnit 9.3, but it works perfectly fine otherwise. In other words, you will currently see the same warning in the test output for PHP 7.4 and the test suite passes just fine on all supported PHP versions. I've discussed these deprecation warnings with @SimonFrings who will address this with a follow-up PR for #364.