Request stream will now be handled internally#132
Merged
WyriHaximus merged 3 commits intoreactphp:masterfrom Feb 21, 2017
Merged
Request stream will now be handled internally#132WyriHaximus merged 3 commits intoreactphp:masterfrom
WyriHaximus merged 3 commits intoreactphp:masterfrom
Conversation
jsor
approved these changes
Feb 21, 2017
WyriHaximus
approved these changes
Feb 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
Requestobject to handle its request stream internally (Law of Demeter). This helps reducing coupling and simplifies adding future PSR-7 methods. All public interfaces are preserved as-is.Builds on top of #130 and #123
This is now in line with #131 (
Responseside of things)Refs #104
Refs #28