Fix ignoring invalid incoming Transfer-Encoding response header#122
Merged
jsor merged 1 commit intoreactphp:masterfrom Feb 8, 2018
Merged
Fix ignoring invalid incoming Transfer-Encoding response header#122jsor merged 1 commit intoreactphp:masterfrom
jsor merged 1 commit intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Feb 8, 2018
jsor
approved these changes
Feb 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change applied, the
Responsewill no longer try to decode incoming responses that use the (invalid)Transfer-Encoding: chunked, chunkedheader. This PR adds a few helper methods that are inspired by PSR-7. Exposing these as part of the public API is left up for #41.Resolves / closes #117
Builds on top of #58