Merged
Conversation
clue
approved these changes
Feb 3, 2017
Member
clue
left a comment
There was a problem hiding this comment.
Yes 👍
This has been discussed plenty of times already and we have yet to come up with a use case that actually needs the tick() method. Removing this makes perfect sense, it avoids plenty of issues related to it, reduces implementation complexity and perceived external complexity (smaller public API).
Member
Author
|
I'd like to hear from @WyriHaximus about this because IIRC he's using |
WyriHaximus
approved these changes
Feb 3, 2017
Member
WyriHaximus
left a comment
There was a problem hiding this comment.
@jsor Glad to see this horrible hack go 👍 . I use it in one lib, but don't really recommend it, and really would prefer not to use and have it at all.
Member
Author
|
Since this a BC break, i'd like to have also @cboden's approval here. |
cboden
approved these changes
Feb 3, 2017
This was referenced Feb 8, 2017
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: #52 (comment), async-interop/event-loop#9
For the tests, i've added a helper function to
TestCase.Closes #52