Mark legacy extensions as deprecated and minor documentation improvements#234
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Jul 10, 2021
Merged
Mark legacy extensions as deprecated and minor documentation improvements#234WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
clue
reviewed
Jul 6, 2021
src/ExtLibevLoop.php
Outdated
| use SplObjectStorage; | ||
|
|
||
| /** | ||
| * Deprecated since v1.2.0, use [`ExtEvLoop`](#extevloop) instead. |
Member
There was a problem hiding this comment.
Should probably use a @deprecated annotation similar to https://github.com/reactphp/event-loop/pull/231/files#diff-f1158fbec0bb446d87dbd5346fba683c58ccec1a98b1787511ec7786585e8c31R8 instead 👍
clue
approved these changes
Jul 10, 2021
Member
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
WyriHaximus
approved these changes
Jul 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maintenance for
ExtLibeventLoopandExtLibevLoophasn't seen an update since 2013. It's time to move on.