Added php8 into travis matrix#221
Closed
mmoreram wants to merge 1 commit intoreactphp:masterfrom
mmoreram:master
Closed
Added php8 into travis matrix#221mmoreram wants to merge 1 commit intoreactphp:masterfrom mmoreram:master
mmoreram wants to merge 1 commit intoreactphp:masterfrom
mmoreram:master
Conversation
Author
|
When adding PHP8 support in the Drift server, I encountered that somehow signals were not dispatched properly. I need to check if this is something related to the pcntl extension (the extension is properly installed in this test job), or if something changed from the last PHP7 version. |
Member
|
@mmoreram Thanks for looking into this! We've successfully verified basic functionality with #215, but have yet to update the test suite to run PHP 8 with all extensions enabled. I'll look into this once reactphp/reactphp#442 is merged 👍 |
Author
|
Thanks @clue I close this PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the PHP requirement in composer allows PHP8, would be nice to have this version inside the travis matrix.