Tick callback receives no arguments, fix cyclic dependency#103
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Apr 28, 2017
Merged
Tick callback receives no arguments, fix cyclic dependency#103WyriHaximus merged 2 commits intoreactphp:masterfrom
WyriHaximus merged 2 commits intoreactphp:masterfrom
Conversation
WyriHaximus
requested changes
Apr 26, 2017
This can easily be replaced by using closure binding as documented.
Member
Author
|
@WyriHaximus Thanks for spotting, updated and squashed! |
Member
|
@clue LGTM |
WyriHaximus
approved these changes
Apr 26, 2017
nrk
approved these changes
Apr 27, 2017
jsor
approved these changes
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tick API has been documented as part of #100, however it makes no mention of how the tick function should look like. It actually currently receives the loop instance, which is entirely undocumented. The loop parameter also causes an unneeded cyclic dependency which hinders garbage collection.
This simple PR changes it so that the tick callback no longer receives a loop argument. This is obviously a small BC break, so this PR ensures to provide some upgrade guides to those affected by this. This is now also in line with the timer API, see #102.
Builds on top of #100 and refs #102
Remove loop argument and suggest using closure binding instead