Fix invalid references in exception stack trace#191
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Feb 11, 2022
Merged
Fix invalid references in exception stack trace#191WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
SimonFrings
approved these changes
Feb 10, 2022
jsor
approved these changes
Feb 10, 2022
WyriHaximus
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes any invalid references in the exception stack trace. This is a pretty nasty bug that has been introduced a while ago with #118 that only happens on PHP 7+ when printing the exception trace (
$exception->getTraceAsString()). This is now covered by the updated test suite and should work across all supported PHP versions.Builds on top of clue/reactphp-socks#104, reactphp/socket#284, and #118