Resolver: support other query classes#159
Resolver: support other query classes#159Thomas-Gelf wants to merge 1 commit intoreactphp:masterfrom
Conversation
This introduces constants for CH (Chaos) and HS (Hesiod) classes and allows to optionally pass type and class to both resolve and resolveAll
WyriHaximus
left a comment
There was a problem hiding this comment.
LGTM, had an interesting read at https://miek.nl/2009/july/31/dns-classes/ 👍
clue
left a comment
There was a problem hiding this comment.
@Thomas-Gelf Thanks for filing this PR, this is an interesting one 👍
I agree that (although rarely used) adding these query classes can be useful 👍
I'm not a fan of modifying the Resolver class however. In particular, if we were to accept this, it should probably affect the ResolverInterface accordingly.
Instead, I don't think this should be exposed in the Resolver/ResolverInterface in the first place. It's my understanding they exist as a higher-level implementation to perform common DNS queries. If you need more control, we also provide a ExecutorInterface to directly work the the underlying DNS messages. Supporting these classes in there would be a no-brainer.
What do you think? 👍
|
@Thomas-Gelf ping |
|
I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. Please come back with more details if you think this is still relevant and we can reopen this 👍 Thank you for your effort nonetheless, keep it up! 👍 |
|
Don't worry, I'm fine with that. Having just this constant without being able to use the |
This introduces constants for CH (Chaos) and HS (Hesiod) classes and
allows to optionally pass type and class to both resolve and resolveAll