Accept DNS ResolverInterface and fix failing test suite#30
Merged
jsor merged 1 commit intoreactphp:masterfrom Jul 18, 2019
Merged
Accept DNS ResolverInterface and fix failing test suite#30jsor merged 1 commit intoreactphp:masterfrom
ResolverInterface and fix failing test suite#30jsor merged 1 commit intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Jul 18, 2019
jsor
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of reactphp/dns#134, all DNS classes are marked as
final, including theResolverclass which is most commonly used in consuming packages. This changeset adjusts ourFactoryto accept theResolverInterfaceinterface as the common interface into this class and also adjust tests to use this interface for mocking. This is not a BC break because the interface is strictly compatible with the originalResolverbehavior.Builds on top of reactphp/socket#208 and reactphp/socket#207
Builds on top of reactphp/dns#139 and reactphp/dns#134