Add issue templates for ReactPHP organisation#3
Merged
clue merged 1 commit intoreactphp:masterfrom Nov 16, 2022
Merged
Conversation
Member
|
@SimonFrings This sounds like a reasonable suggestion and I agree that it makes sense to reconsider the decision made in reactphp/reactphp#466. I'm 👍 on this provided we revert the changes done in the component repositories. You've also mentioned enabling blank issues, do you plan to create a separate follow-up PR or should this be part of this PR? |
Member
Author
|
@clue This is already part of this PR. I have actively disabled blank issues in my other PRs by adding the following line to the Blank issues are automatically enabled by GitHub if I don't use this option. |
WyriHaximus
approved these changes
Nov 15, 2022
clue
approved these changes
Nov 16, 2022
Member
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the looking into this and for the confirmation, changes LGTM! ![]()
This was referenced Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently proposed to add issue templates to all ReactPHP repositories, you can find the original discussion regarding this topic in reactphp/reactphp#466. By the time I thought it would be the best way to manually add them to most of the ReactPHP repos for the following reason (full conversation):
So we decided to introduce issue templates the way I proposed it and I started opening up pull requests in some ReactPHP repositories e.g. reactphp/reactphp#466, reactphp/http#475 which have already been merged. There are still repositories missing these changes.
I started talking with @clue about this and noticed that it should be possible to open up blank issues, which I disabled in my recently submitted pull requests. This means I have to open up a second pull request in every repository which already supports issue templates. The same goes for every future adjustments, seems a bit overkill to open more than 10 pull requests for this, right?
On a second thought it would be more wise to add issue templates on an organisational level, to keep future adjustments for these templates rather small and simple. Yes, repositories like reactphp/branding will also receive those templates, but how big of a deal is it anyway.
If we decide to go this path, we'd laso have to revert my already merged pull request. This will seem a little strange to the outside and is why I provide all this information in here, so people might understand our behavior.
@WyriHaximus and @clue, what do you think?