Move SSL/TLS context options to SecureConnector#43
Move SSL/TLS context options to SecureConnector#43cboden merged 1 commit intoreactphp-legacy:masterfrom
Conversation
* TLS endpoints do not have to match connection endpoints (proxy setup) * More SOLID design, better separation of concerns
|
How can we make this work well with #17? |
Afaict this isn't (directly) affected. I've updated #4 to list some concerns (separation of concerns, API design, usability etc.) with the initial approach in #17, so I'm not sure #17 should block this feature.
Personally, I would suggest building SSL/TLS context options on top of this changeset, also for the following reason:
The underlying TCP/IP connection endpoints (handled via Client A connects to proxy B which connects to target C In this scenario, client A needs to establish an underlying TCP/IP connection to proxy B while its TLS endpoint would be target C. See also the linked tickets for some background. I'll look into filing an alternative to #17 in the next days :) |
Ping @WyriHaximus, @cboden |
|
@clue alright good makes sense LGTM 👍 |
Move SSL/TLS context options to SecureConnector
This change also makes it easy to introduce additional SSL/TLS context options in the future.
Required for SOCKS proxy (clue/reactphp-socks#28) and eventually HTTP proxy (reactphp/http-client#44).