docs: translate Keeping Components Pure page #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mhaidarhanif
left a comment
There was a problem hiding this comment.
Need confirmation from the others. Also might have to be addressed in the Glossary later too.
67921a3 to
4ef6f3c
Compare
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mhaidarhanif
requested changes
Apr 28, 2023
Collaborator
mhaidarhanif
left a comment
There was a problem hiding this comment.
Some suggestions to consider.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
638d20c to
913ae1d
Compare
0100a12 to
bc61a0d
Compare
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mhaidarhanif
approved these changes
Apr 29, 2023
Collaborator
bc61a0d to
9357b4b
Compare
zainfathoni
approved these changes
Apr 29, 2023
Collaborator
zainfathoni
left a comment
There was a problem hiding this comment.
LGTM with some minor comments. Thanks!
r17x
approved these changes
Apr 29, 2023
e229fbc to
7f2f91e
Compare
r17x
pushed a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to translate
Keeping Components Purepage to Indonesian.Related to #330
Closes #435