Remove wrapper around ListEmptyComponent

[AntoineDoubovetzky]

Summary

This pull request fixes #24257.

The wrapper around ListEmptyComponent doesn't allow to use flex on the ListEmptyComponent.
The wrapper was removed in this commit, and then put back in this commit but I think the relevant part was removing the condition on itemCount !== 0 to apply the inversionStyle on the ScrollView and everything is still working without the wrapper.

Changelog

[GENERAL] [FIXED] - Remove wrapper around ListEmptyComponent

Test Plan

Here is the code I used to test:

<FlatList
  data={[]}
  keyExtractor={item => item}
  contentContainerStyle={{ flex: 1 }}
  ListEmptyComponent={
    <View
      style={{
        flex: 1,
        backgroundColor: 'red',
      }}
    >
      <Text>Empty</Text>
    </View>
  }
  ListFooterComponent={
    <View
      style={{
        backgroundColor: '#D6D6D6',
        paddingVertical: 6,
        marginVertical: 6,
        borderRadius: 20,
        alignItems: 'center',
        paddingHorizontal: 15,
      }}
    >
      <Text>FOOTER</Text>
    </View>
  }
  ListHeaderComponent={
    <View
      style={{
        backgroundColor: '#D6D6D6',
        paddingVertical: 6,
        marginVertical: 6,
        borderRadius: 20,
        alignItems: 'center',
        paddingHorizontal: 15,
      }}
    >
      <Text>HEADER</Text>
    </View>
  }
  renderItem={({item}) => <Text>{item}</Text>}
/>

The ListEmptyComponent is taking the full height (or full width in horizontal mode) as expected. And it is not rendered upside down when the FlatList is inverted:

Vertical, not inverted:

Vertical, inverted:

Horizontal, not inverted:

Horizontal, inverted:

[cpojer]

Thanks for sending a PR! It seems like that is the better solution.

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @AntoineDoubovetzky in 4627644.

^{When will my fix make it into a release? | Upcoming Releases}

[elyalvarado]

This should also fix issue #17944