fix: Add ESM unwrapping to all CommonJS require calls#1675
Closed
kitten wants to merge 3 commits into
Closed
Conversation
fa7ed4b to
d831001
Compare
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this in D102510513. |
kitten
commented
May 5, 2026
Comment on lines
+80
to
+81
| const extractor = | ||
| mod.__esModule === true && 'default' in mod ? mod.default : mod; |
Contributor
Author
There was a problem hiding this comment.
Spotted on a re-review that getCacheKey below means that we should be doing:
const getCacheKey =
mod?.getCacheKey ??
(mod.__esModule === true && 'default' in mod ? mod.default : mod).getCacheKey;
kitten
added a commit
to expo/expo
that referenced
this pull request
May 5, 2026
kitten
added a commit
to expo/expo
that referenced
this pull request
May 5, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was added to
loadConfig.jsbut is missing in other places. While it's arguably not useful in many cases in a "standard" Metro setup with Metro's own packages, it'd be nice to have this behave consistently even with transpiled ESM output (or with require-ESM in Node).Specifically this affects:
requiregetMinifierimplementationbabelTransformerPathloadingThis is probably specifically interesting for
babelTransformerPathwhich is often overridden by third-party setups.Changelog: [Fix] Unwrap ES modules when requiring metro-file-map workers, asset plugins, the minifier, or the babel transformer
Test plan
loadConfig.js