Skip to content

Don't block static files in robots.txt#7508

Merged
iansu merged 2 commits into
masterfrom
iansu-patch-1
Aug 12, 2019
Merged

Don't block static files in robots.txt#7508
iansu merged 2 commits into
masterfrom
iansu-patch-1

Conversation

@iansu

@iansu iansu commented Aug 10, 2019

Copy link
Copy Markdown
Contributor

This was introduced in #7482

@iansu

iansu commented Aug 10, 2019

Copy link
Copy Markdown
Contributor Author

I know I also have to update the TypeScript template. I was trying to do this through GitHub.

@ianschmitz ianschmitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ditch the file completely or do you think it still has value?

@ianschmitz ianschmitz added this to the 3.1.1 milestone Aug 11, 2019
@iansu

iansu commented Aug 11, 2019

Copy link
Copy Markdown
Contributor Author

We should probably release 3.1.1 with this fix.

@iansu

iansu commented Aug 11, 2019

Copy link
Copy Markdown
Contributor Author

@ianschmitz I believe it's necessary to get the 100% score on Lighthouse.

@mrmckeb

mrmckeb commented Aug 11, 2019

Copy link
Copy Markdown
Contributor

Yes, let's leave the file - we as we want to retain that 100%. It's a good win.

@iansu iansu merged commit a21e6b1 into master Aug 12, 2019
@iansu iansu deleted the iansu-patch-1 branch August 14, 2019 02:42
@lock lock Bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants