Skip to content

Add box-sizing: border-box to all elements by default#6348

Closed
jordanoverbye wants to merge 1 commit into
react:masterfrom
jordanoverbye:template-css-border-box
Closed

Add box-sizing: border-box to all elements by default#6348
jordanoverbye wants to merge 1 commit into
react:masterfrom
jordanoverbye:template-css-border-box

Conversation

@jordanoverbye

Copy link
Copy Markdown

No description provided.

@mrmckeb mrmckeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great change, more important IMO than the other CSS we ship with. But, it will be a breaking change - even if the templates aren't replaced when bumping React scripts.

@robertvansteen

Copy link
Copy Markdown
Contributor

This should be a user choice in my opinion. I always apply this to my projects but I know what it does. I don’t think everyone new to React or front-end development will know what the effect of this rule is. CRA shouldn’t be a CSS reset.

@jordanoverbye

Copy link
Copy Markdown
Author

Thanks for your feedback @mrmckeb and @rovansteen! I agree that CRA shouldn't be a CSS reset - but I believe this change will benefit the majority of CRA users, and for those people who are new to front-end or CRA these additions are no different to the CSS CRA is currently shipped with.

@mrmckeb

mrmckeb commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

I've discussed this with more of the core team, and while I think most of us agree that everyone in the world should turn this on, we're going to hold off on this for now.

Stay tuned, we're definitely looking into improving the out-of-box template experience.

@mrmckeb mrmckeb closed this Feb 7, 2019
@lock lock Bot locked and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants