Added testIDS prop which can be used to pass testID to individual segment buttons#894
Merged
Naturalclar merged 1 commit intoOct 23, 2024
Conversation
ee9d29f to
26952c6
Compare
Member
|
will fix the lint issue and publish today |
Contributor
Author
|
Thanks for meging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Thanks for creating this owesome library. There is a small concern, even though it is very helpful. There is no feature for sending testIDs for individual segment buttons/components. I've done with the implementation of this feature for both Android and iOS and creating this PR. I hope this could get merged quickly, as we are in need of this change.
Test Plan
Send an array of identifiers into testIDS and check if they are reflecting or not.
ex:
<SegmentController
{...props}
testIDS={["option1", "option2", "option3"]}
/>