Skip to content

feat: better accessibility hinting#817

Merged
Naturalclar merged 1 commit into
react-native-segmented-control:masterfrom
uncinc:master
Jan 3, 2024
Merged

feat: better accessibility hinting#817
Naturalclar merged 1 commit into
react-native-segmented-control:masterfrom
uncinc:master

Conversation

@boazpoolman

@boazpoolman boazpoolman commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

Overview

Implements the suggestions given in #109.
This resembles the mechanics of the native iOS UISegmentedControl but then for Android.

@pandu-supriyono

Copy link
Copy Markdown

I believe Android/Talback exposes some API to announce list items. I would prefer an approach that doesn't involve handling some form of i18n on a per-project basis, such that we can flexibly respect the user's language settings on their device.

@boazpoolman

Copy link
Copy Markdown
Contributor Author

That would indeed be nice.
Sadly I was unable to make that work.

@Naturalclar Naturalclar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Naturalclar Naturalclar merged commit fd7c851 into react-native-segmented-control:master Jan 3, 2024
github-actions Bot pushed a commit that referenced this pull request Jan 3, 2024
# [2.5.0](v2.4.2...v2.5.0) (2024-01-03)

### Bug Fixes

* fix the slider text for android when selected ([#703](#703)) ([088daa6](088daa6))

### Features

* better accessibility hinting ([#817](#817)) ([fd7c851](fd7c851))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants