Draft
Conversation
BREAKING CHANGE: - node < 18, and CommonJS, are no longer supported
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
reviewed
Nov 25, 2024
Collaborator
jonkoops
left a comment
There was a problem hiding this comment.
Looks like this contains some breaking changes, so let's not merge this until we are sure we want to do a major release.
Collaborator
Author
Yeah, it needs a rebase. But that will mess up semantic-release as we discussed in file-selector. |
Collaborator
|
I think what we can do is backport fixes from
That way we don't have to deal with a nasty merge/rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
This PR will get all the changes from
betatomainand trigger a major release.Does this PR introduce a breaking change?
Yes, there are a few breaking changes:
Other information