Skip to content

feat: Add statsdreporter to bq sink #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Meghajit merged 10 commits into from
Sep 27, 2022
Merged

feat: Add statsdreporter to bq sink #196

Meghajit merged 10 commits into from
Sep 27, 2022

Conversation

@lavkesh
Copy link
Member

@lavkesh lavkesh commented Sep 23, 2022 •
edited by Meghajit
Loading

Closes #197

@lavkesh lavkesh changed the title Feat/bq sink depot Feat Sep 23, 2022
@lavkesh lavkesh changed the title Feat feat: Add statsdreporter to bq sink Sep 23, 2022
@Meghajit
Copy link
Member

Meghajit commented Sep 26, 2022

@lavkesh Can we create a GitHub issue for this PR with some description ?
It's a good practice to link a PR with an issue, as otherwise there is not much information available on why the PR was needed in the first place.

@Meghajit Meghajit self-requested a review September 26, 2022 05:11
Meghajit
Meghajit reviewed Sep 26, 2022
View reviewed changes
@Meghajit Meghajit linked an issue Sep 27, 2022 that may be closed by this pull request
feat: enable metrics to be sent by BigQuery Sink #197
Closed
@Meghajit Meghajit merged commit cdf61cb into main Sep 27, 2022
@Meghajit Meghajit deleted the feat/bq-sink-depot branch September 27, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meghajit Meghajit Meghajit left review comments

Assignees

@lavkesh lavkesh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: enable metrics to be sent by BigQuery Sink

4 participants

@lavkesh @Meghajit @sumitaich1998