Skip to content

Conversation

@Meghajit
Copy link
Member

No description provided.

Meghajit added 30 commits June 21, 2022 14:08
- add new package types for flink and statsd measurements

[raystack#108]
- Dagger will use its own version to send metrics to
telegraf. Keeping multiple versions of the same
dependency can be avoided here.

[raystack#108]
- use statsDReporter for raising metrics

[raystack#108]
-  revert package names refactoring

[raystack#108]
- return empty string in getMetricStatsDTags

[raystack#108]
- global tags fail to be sent if statsdClient is used
- remove unused interface methods

[raystack#108]
@Meghajit Meghajit self-assigned this Jul 8, 2022
@Meghajit Meghajit linked an issue Jul 8, 2022 that may be closed by this pull request
@Meghajit Meghajit marked this pull request as ready for review July 8, 2022 15:34
Meghajit added 2 commits July 11, 2022 12:56
- FileRecordFormat object and all it's fields need to be serializable
in order to construct the Flink job graph. Even though StatsDErrorReporter is
made serializable, it contains StatsDErrorReporter, which in turn
contains more fields which may not be serializable.Hence, in order to
mitigate job graph creation failures, we wrap the error reporter inside a
serializable lambda. This is a common idiom to make un-serializable
fields serializable in Java 8: https://stackoverflow.com/a/22808112

[raystack#108]
@Meghajit
Copy link
Member Author

Created a PR from a branch of dagger instead of personal fork:
#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant