-
Notifications
You must be signed in to change notification settings - Fork 42
feat: Add parquet source metrics #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Meghajit
wants to merge
47
commits into
raystack:dagger-parquet-file-processing
from
Meghajit:feat/issue#108-add-parquet-source-metrics
Closed
feat: Add parquet source metrics #171
Meghajit
wants to merge
47
commits into
raystack:dagger-parquet-file-processing
from
Meghajit:feat/issue#108-add-parquet-source-metrics
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5eccb23.
This reverts commit 9d0c8e8.
- add new package types for flink and statsd measurements [raystack#108]
- Dagger will use its own version to send metrics to telegraf. Keeping multiple versions of the same dependency can be avoided here. [raystack#108]
- remove unused imports [raystack#108]
- use statsDReporter for raising metrics [raystack#108]
- revert package names refactoring [raystack#108]
- return empty string in getMetricStatsDTags [raystack#108]
- global tags fail to be sent if statsdClient is used - remove unused interface methods [raystack#108]
- refactor flow for null tag value [raystack#108]
- FileRecordFormat object and all it's fields need to be serializable in order to construct the Flink job graph. Even though StatsDErrorReporter is made serializable, it contains StatsDErrorReporter, which in turn contains more fields which may not be serializable.Hence, in order to mitigate job graph creation failures, we wrap the error reporter inside a serializable lambda. This is a common idiom to make un-serializable fields serializable in Java 8: https://stackoverflow.com/a/22808112 [raystack#108]
Member
Author
|
Created a PR from a branch of dagger instead of personal fork: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.