Feat: handle invalid parquet data source configs #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added split assigners to assign splits based on timestamp in url and based on index in filepaths array [raystack#99]
- add methods to get FileSplitAssigner and FileRecordFormat based on configs - pass StencilClientOrchestrator to SourceFactory as well when creating the source [raystack#99]
- this is required for parsing the parquet SimpleGroup data structure into Java objects. [raystack#99]
- implement parsers for int32, int64 and boolean parquet data types [raystack#99]
- remove abstract method serializer from the interface as it is not required [raystack#99]
- return DaggerDeserializationException instead of ClassCastException when logical type is incorrect [raystack#99]
- return DaggerDeserializationException instead of ClassCastException when logical type is incorrect [raystack#99]
- change the class to a usual class instead of a factory class [raystack#99]
- ParquetDataTypeParser.getValueOrDefault() now returns the default value only if the deserialized value is null. [raystack#99]
- add validation methods to check if SimpleGroup map schema follows Apache Parquet LogicalTypes spec or legacy one - official spec https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#backward-compatibility-rules-1 - add some tests [raystack#137]
- add tests - refactor implementation of the original method into smaller modular methods [raystack#137]
…lizer - remove unnecessary test [raystack#137]
- remove proto keyword - update usages - this fixes for review comment raystack#138 (comment) and raystack#138 (comment) [raystack#138]
…00-parquet-complex-and-repeated-datatype-deserialization
- replace transformFromKafka with transformFromProto - fixes for review comment raystack#140 (comment) [raystack#140]
…serialization' into feat/issue#137-parquet-map-and-group-timestamp-deserialization
…files-and-packages
…00-parquet-complex-and-repeated-datatype-deserialization
…serialization' into feat/issue#137-parquet-map-and-group-timestamp-deserialization
…nvalid-parquet-data-source-configs
- add validator class [raystack#150]
- replace `KafkaTransform` keyword [raystack#100]
…' into feat/issue#100-parquet-complex-and-repeated-datatype-deserialization
…serialization' into feat/issue#137-parquet-map-and-group-timestamp-deserialization
…' into feat/issue#137-parquet-map-and-group-timestamp-deserialization
…ization' into feat/issue#150-handle-invalid-parquet-data-source-configs
…' into feat/issue#150-handle-invalid-parquet-data-source-configs # Conflicts: # dagger-core/src/main/java/io/odpf/dagger/core/source/config/StreamConfig.java # dagger-core/src/main/java/io/odpf/dagger/core/source/config/adapter/FileDateRangeAdaptor.java # dagger-core/src/main/java/io/odpf/dagger/core/source/parquet/splitassigner/ChronologyOrderedSplitAssigner.java # dagger-core/src/test/java/io/odpf/dagger/core/source/config/StreamConfigTest.java # dagger-core/src/test/java/io/odpf/dagger/core/source/config/adapter/FileDateRangeAdaptorTest.java # dagger-core/src/test/java/io/odpf/dagger/core/source/parquet/ParquetFileSourceTest.java # dagger-core/src/test/java/io/odpf/dagger/core/source/parquet/splitassigner/ChronologyOrderedSplitAssignerTest.java
prakharmathur82
requested changes
May 25, 2022
dagger-core/src/main/java/io/odpf/dagger/core/source/config/StreamConfigValidator.java
Show resolved
Hide resolved
dagger-core/src/main/java/io/odpf/dagger/core/source/config/models/TimeRanges.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/odpf/dagger/core/source/config/adapter/SourceParquetFilePathsAdapter.java
Outdated
Show resolved
Hide resolved
dagger-core/src/test/java/io/odpf/dagger/core/source/config/models/TimeRangesTest.java
Outdated
Show resolved
Hide resolved
dagger-core/src/test/java/io/odpf/dagger/core/source/config/StreamConfigTest.java
Outdated
Show resolved
Hide resolved
dagger-core/src/test/java/io/odpf/dagger/core/source/config/StreamConfigTest.java
Show resolved
Hide resolved
...c/test/java/io/odpf/dagger/core/source/config/adapter/SourceParquetFilePathsAdapterTest.java
Show resolved
Hide resolved
- was added during merge conflict resolution - fixes review comment https://github.com/odpf/dagger/pull/152/files#r881910875 and https://github.com/odpf/dagger/pull/152/files#r881563904 [raystack#150]
- fixes review comment raystack#152 (comment) and raystack#152 (comment) [raystack#150]
- fixes review comment raystack#152 (comment) and raystack#152 (comment) [raystack#150]
prakharmathur82
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #150