fix: enable read gcs file from local #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dagger-functions/src/main/java/io/odpf/dagger/functions/udfs/python/PythonUdfConfig.java # dagger-functions/src/main/java/io/odpf/dagger/functions/udfs/python/PythonUdfManager.java # dagger-functions/src/test/java/io/odpf/dagger/functions/udfs/python/PythonUdfConfigTest.java # dagger-functions/src/test/java/io/odpf/dagger/functions/udfs/python/PythonUdfManagerTest.java # dagger-functions/src/test/resources/test_udf.py
prakharmathur82
requested changes
May 24, 2022
...er-functions/src/main/java/io/odpf/dagger/functions/exceptions/PythonFilesNullException.java
Outdated
Show resolved
Hide resolved
...-functions/src/main/java/io/odpf/dagger/functions/udfs/python/file/type/FileTypeFactory.java
Outdated
Show resolved
Hide resolved
dagger-functions/src/main/java/io/odpf/dagger/functions/udfs/python/file/type/ZipFileType.java
Outdated
Show resolved
Hide resolved
...ctions/src/main/java/io/odpf/dagger/functions/udfs/python/file/source/FileSourceFactory.java
Outdated
Show resolved
Hide resolved
...r-functions/src/main/java/io/odpf/dagger/functions/udfs/python/file/type/PythonFileType.java
Show resolved
Hide resolved
...-functions/src/main/java/io/odpf/dagger/functions/udfs/python/file/source/gcs/GcsClient.java
Show resolved
Hide resolved
...ctions/src/test/java/io/odpf/dagger/functions/udfs/python/file/source/GcsFileSourceTest.java
Outdated
Show resolved
Hide resolved
...ions/src/test/java/io/odpf/dagger/functions/udfs/python/file/source/LocalFileSourceTest.java
Outdated
Show resolved
Hide resolved
...nctions/src/test/java/io/odpf/dagger/functions/udfs/python/file/type/PythonFileTypeTest.java
Show resolved
Hide resolved
...-functions/src/test/java/io/odpf/dagger/functions/udfs/python/file/type/ZipFileTypeTest.java
Show resolved
Hide resolved
* refactor: revert back to not publish python package * refactor: update requirements.txt * feat: publish python zip on release
prakharmathur82
requested changes
May 30, 2022
dagger-functions/src/test/java/io/odpf/dagger/functions/udfs/python/PythonUdfManagerTest.java
Outdated
Show resolved
Hide resolved
...nctions/src/test/java/io/odpf/dagger/functions/udfs/python/file/type/PythonFileTypeTest.java
Outdated
Show resolved
Hide resolved
prakharmathur82
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.