Skip to content

PR#252 rebased#253

Merged
ravi9 merged 2 commits into
dev_backend_openvinofrom
pr-252-rebased
Jul 14, 2026
Merged

PR#252 rebased#253
ravi9 merged 2 commits into
dev_backend_openvinofrom
pr-252-rebased

Conversation

@ravi9

@ravi9 ravi9 commented Jul 14, 2026

Copy link
Copy Markdown
Owner

PR#252 rebased.

This pull request refactors how model inputs and extra inputs are represented and handled in the OpenVINO backend, replacing direct use of OpenVINO node objects with new structured info types. The changes improve abstraction, simplify input management, and make the codebase more maintainable and extensible. Key updates include the introduction of ModelInputInfo and ModelExtraInputInfo structs, updates to interfaces and internal data structures, and refactoring of related logic to use these new types.

API and Data Structure Refactoring:

  • Introduced ModelInputInfo and ModelExtraInputInfo structs to represent model inputs and extra inputs, respectively, encapsulating type, shape, value, and parameter status. (ggml/src/ggml-openvino/openvino/decoder.h)
  • Updated interface methods in GgmlDecoder and its implementations to use these new structs instead of std::shared_ptr<ov::Node>. (ggml/src/ggml-openvino/openvino/decoder.h, ggml/src/ggml-openvino/ggml-decoder.h) [1] [2] [3]

Logic and Implementation Updates:

  • Refactored creation and storage of model inputs and extra inputs in GgmlOvDecoder to use the new structs, simplifying logic and removing redundant code. (ggml/src/ggml-openvino/ggml-decoder.cpp) [1] [2] [3]
  • Updated input node construction in the translation session to use helper functions that build OpenVINO nodes from the new info structs, ensuring consistent parameter and constant creation. (ggml/src/ggml-openvino/openvino/translate_session.cpp) [1] [2]

Utility Function Update:

  • Modified utility code to construct input tensors from the new ModelExtraInputInfo struct, removing the need for a separate map of extra input values. (ggml/src/ggml-openvino/utils.cpp)

Dependency Cleanup:

  • Removed unnecessary OpenVINO header includes, reflecting the reduced direct dependency on OpenVINO node types in header files. (ggml/src/ggml-openvino/ggml-decoder.cpp)

These changes collectively improve code clarity and set the stage for easier future modifications to input handling.## Overview

Additional information

Requirements

@ravi9 ravi9 merged commit 396adc3 into dev_backend_openvino Jul 14, 2026
7 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants