PR#252 rebased#253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR#252 rebased.
This pull request refactors how model inputs and extra inputs are represented and handled in the OpenVINO backend, replacing direct use of OpenVINO node objects with new structured info types. The changes improve abstraction, simplify input management, and make the codebase more maintainable and extensible. Key updates include the introduction of
ModelInputInfoandModelExtraInputInfostructs, updates to interfaces and internal data structures, and refactoring of related logic to use these new types.API and Data Structure Refactoring:
ModelInputInfoandModelExtraInputInfostructs to represent model inputs and extra inputs, respectively, encapsulating type, shape, value, and parameter status. (ggml/src/ggml-openvino/openvino/decoder.h)GgmlDecoderand its implementations to use these new structs instead ofstd::shared_ptr<ov::Node>. (ggml/src/ggml-openvino/openvino/decoder.h,ggml/src/ggml-openvino/ggml-decoder.h) [1] [2] [3]Logic and Implementation Updates:
GgmlOvDecoderto use the new structs, simplifying logic and removing redundant code. (ggml/src/ggml-openvino/ggml-decoder.cpp) [1] [2] [3]ggml/src/ggml-openvino/openvino/translate_session.cpp) [1] [2]Utility Function Update:
ModelExtraInputInfostruct, removing the need for a separate map of extra input values. (ggml/src/ggml-openvino/utils.cpp)Dependency Cleanup:
ggml/src/ggml-openvino/ggml-decoder.cpp)These changes collectively improve code clarity and set the stage for easier future modifications to input handling.## Overview
Additional information
Requirements