RDBC-1032 Operation.wait_for_completion() returns BulkOperationResult#274
Open
redknightlois wants to merge 1 commit intoravendb:v7.1from
Open
RDBC-1032 Operation.wait_for_completion() returns BulkOperationResult#274redknightlois wants to merge 1 commit intoravendb:v7.1from
redknightlois wants to merge 1 commit intoravendb:v7.1from
Conversation
- BulkOperationResult deserialized from the operation state Result payload - Fields: total, documents_processed, attachments_processed, counters_processed, time_series_processed, query, details (list of per-document detail dicts) - message property returns "Processed N items." matching C# IOperationResult contract - fetch_operations_status() retries up to 10 times (500ms apart) when the server returns null state, then raises InvalidOperationException — mirrors C# race-condition handling for operations registered after the first poll - wait_for_completion(timeout) accepts an optional timedelta; raises TimeoutError when the operation does not complete within the specified duration; sleep is capped to the remaining deadline to avoid overshoot - details is empty when RetrieveDetails is not set in QueryOperationOptions; non-empty when RetrieveDetails=True (mirrors C# RavenDB_2936 test contract) - Integration test verifies patched documents reflect the updated values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1032
Additional description
RDBC-1032 –
Operation.wait_for_completion()previously returnedNone, making it impossible to inspect the outcome of bulk operations programmatically. It now returns aBulkOperationResultcontaining the total number of items processed and per-document details, matching the C#IOperationResultcontract. The method also accepts an optional timeout and raisesTimeoutErrorif the operation does not complete in time.Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.