DisableAllFieldObjects()

[mmtwr]

Describe the bug
I am trying to use DisableAllFieldObjects() to disable all of the fields on a modeled form, Brief Addiction Monitor.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Brief Addiction Monitor'
2. Click on 'Edit' with client 1717 in UAT
3. See error preventing form loading:
   

Expected behavior
I expect that on form load fields will be disabled. I want only the 'Category' field enabled.

Screenshots
In this image you can see the fields are beginning to appear disabled:

However, this image shows not all fields are getting disabled, specifically question 11:

Desktop (please complete the following information):

• OS: Windows 10 Pro
• Browser Chrome (latest)
• Version 83

Additional context
`using NLog;
using RarelySimple.AvatarScriptLink.Objects;
using Rosecrance.ScriptLinkService.Data.Models;
using Rosecrance.ScriptLinkService.Data.Repositories;
using System;
using System.Collections.Generic;
using System.Data.Odbc;

namespace Rosecrance.ScriptLinkService.Web.Commands
{
public class BAMFormLoadCommand : IRunScriptCommand
{
// ***********************************************************************************************
// Brief Addiction Monitor BAM FORM load
// -------------------------
// The form load function will disable all fields except the Category
// ***********************************************************************************************

    private static readonly Logger logger = LogManager.GetCurrentClassLogger();
    private readonly OptionObject2015 _optionObject2015;
    private readonly IGetDataRepository _repository;

    public BAMFormLoadCommand(OptionObject2015 optionObject2015, IGetDataRepository repository)
    {
        _optionObject2015 = optionObject2015;
        _repository = repository;
    }

    public OptionObject2015 Execute()
    {
        try
        {               
            string dateOfAssessmentFieldNumber = "263.89";
            string categoryFieldNumber = "264.13";
            string methodOfAdministration = "263.92";               
            
            logger.Debug("Method of Administration IsFieldEnabled before: " + _optionObject2015.IsFieldEnabled(methodOfAdministration));
            logger.Debug("Method of Administration IsFieldLocked before: " + _optionObject2015.IsFieldLocked(methodOfAdministration));

            _optionObject2015.SetEnabledField(categoryFieldNumber);
           
            List<string> fields = new List<string>();
            fields.Add(dateOfAssessmentFieldNumber);
            fields.Add("263.90");
            fields.Add(methodOfAdministration);
            fields.Add("263.93");
            fields.Add("263.94");
            fields.Add("263.95");
            fields.Add("263.96");
            fields.Add("263.97");
            fields.Add("263.98");
            fields.Add("263.99");
            fields.Add("264");
            fields.Add("264.01");
            fields.Add("264.02");
            fields.Add("264.03");
            fields.Add("264.04");
            fields.Add("264.05");
            fields.Add("264.06");
            fields.Add("264.07");
            fields.Add("264.08");
            fields.Add("264.09");
            fields.Add("264.10");
            fields.Add("264.11");
            //fields.Add("");
            //fields.Add("");
            _optionObject2015.SetDisabledFields(fields);
            _optionObject2015.DisableAllFieldObjects();
            //_optionObject2015.SetDisabledField("263.89");
            //_optionObject2015.SetDisabledField("263.90"); 
            //_optionObject2015.SetDisabledField(methodOfAdministration);                
        }

        catch (OdbcException ex)
        {
            logger.Error(ex, "An ODBC exception has occurred. See ODBC Data log for more detail.");
            return _optionObject2015.ToReturnOptionObject(ErrorCode.Error, "An ODBC exception has occurred. See the ODBC Data log on the web server for more detail.");
        }
        catch (Exception ex)
        {
            logger.Error(ex, "An unexpected error occurred. Error: {errorMessage}", ex.Message);
            return _optionObject2015.ToReturnOptionObject(ErrorCode.Error, "An unexpected error occurred. Please contact your system administrator. Error: " + ex.Message);
        }

        return _optionObject2015.ToReturnOptionObject();
    }
}

}`

[mmtwr]

Another issue I am having is the behavior based on whether you choose to either click 'Add' for a new form, or 'Edit' to edit an existing form. Expected behavior is that if this is a new form to allow all fields to be used, but if you are editing and existing form it should only allow the 'Category'. Where is it determined whether you are opening new form or editing an existing?

[scottolsonjr]

Can you try this code snippet and let me know the following:

• Do you get an error message?
• Do the fields get disabled?

    public OptionObject2015 Execute()
    {
        try
        {               
            string dateOfAssessmentFieldNumber = "263.89";
            string categoryFieldNumber = "264.13";
            string methodOfAdministration = "263.92";

            //if (_optionObject2015.IsFieldPresent(dateOfAssessmentFieldNumber) && _optionObject2015.GetFieldValue(dateOfAssessmentFieldNumber) != "")
            //{
                _optionObject2015.DisableAllFieldObjects();
                _optionObject2015.SetEnabledField(categoryFieldNumber);
            //}
        }
        catch (Exception ex)
        {
            logger.Error(ex, "An unexpected error occurred. Error: {errorMessage}", ex.Message);
            return _optionObject2015.ToReturnOptionObject(ErrorCode.Error, "An unexpected error occurred. Please contact your system administrator. Error: " + ex.Message);
        }

        return _optionObject2015.ToReturnOptionObject();
    }

[mmtwr]

There is no error message and the fields do not get disabled.

[scottolsonjr]

I have identified the issue. If myAvatar does not send the Enabled and/or Required properties with the OptionObject then DisableAllFieldObjects() fails.

[scottolsonjr]

The fix for this is included in v.1.0.5 on NuGet.

[mmtwr]

I updated to new NuGet package, but it still does not disable fields. Did I need to change anything in code or continue to use the sample you provided?

[scottolsonjr]

Can you send the new Verbose log? Also, do all the unit tests pass?

…

On Mon, Jun 8, 2020 at 8:09 AM Matt Becker ***@***.***> wrote: I updated to new NuGet package, but it still does not disable fields. Did I need to change anything in code or continue to use the sample you provided? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHQNC5NMFQ2XAXDB6XGHALRVT5MJANCNFSM4NRYM2NA> .

[mmtwr]

All tests pass.