test: add unit tests for internal packages#164
Open
ppn26 wants to merge 4 commits into
Open
Conversation
Covers ParseTrigger() and Matches() with table-driven tests for all valid inputs, error cases, and edge cases. Brings hooktrigger from 0% to ~95% coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for Init(), unknown message handling, full progress view, SetProgress before Start, and double Stop idempotency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for non-table hook values, empty commands, matchPattern boundaries, IsEnabled default, and empty forge rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests to cover previously uncovered code paths: - registry: Load/Save with default path (exercises registryPath/WtDir), Save creates parent dirs, round-trip JSON, missing file, invalid JSON, RemoveLabel/ClearLabels/AddLabel error paths, PathExists for non-existent path, resolveAsPath - preserve: CopyFile when dst parent is a file (MkdirAll error path), FindSourceWorktree with invalid git dir, FindIgnoredFiles on non-git directory Coverage: internal/registry 84.4% → 94.1%, internal/preserve 72.2% → 87.5% Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for pure-logic internal packages to improve test coverage.
internal/hooktrigger: 0% → 97.9% (ParseTrigger + Matches)internal/config: edge cases for parseHooksConfig, matchPattern, IsEnabled, GetForgeTypeForRepointernal/ui/progress: extend progressBarModel tests (Init, View, Update branches)internal/registry: 84.4% → 94.1% (Save, Load, RemoveLabel, ClearLabels, PathExists)internal/preserve: 72.2% → 87.5% (CopyFile, FindSourceWorktree, FindIgnoredFiles)Test Coverage
🤖 Generated with Claude Code