fix: include tasks in DeleteFileAtomic transaction#208
Merged
Conversation
ea78a14 to
16463d4
Compare
Add DELETE FROM task to DeleteFileAtomic transaction and explicit associated-data cleanup to DeleteFilesByPrefix, ensuring tasks are cleaned up synchronously rather than relying solely on async cascade events that can silently fail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
16463d4 to
8c52b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE FROM task WHERE file = ...to theDeleteFileAtomictransaction, ensuring tasks are cleaned up atomically alongside chunks, wiki links, and label edgescascade_delete_file_tasks), which could silently fail after 3 retries and leave orphaned rowsTestDeleteFileAtomicto create a task before deletion and verify it's removedTest plan
just testpassesTestDeleteFileAtomiccovers task cleanup🤖 Generated with Claude Code