fix(fsdp): apply set_attention_backend per raw model (wan2.2) - #20
Merged
Merged
Conversation
The wan2.2 refactor moved DiT loading to a raw_models dict + per-component loop, but left the set_attention_backend call outside the loop referencing an undefined `model` — so `--fsdp-attention-backend` raised NameError (the default None path hid it). Move it into the loop, on each raw component before LoRA/FSDP wrapping, so wan2.2's two transformers both get it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wan2.2 refactor moved DiT loading to a raw_models dict + per-component loop, but conflicts the set_attention_backend call outside the loop referencing an undefined
model— so--fsdp-attention-backendraised NameError (the default None path hid it). Move it into the loop, on each raw component before LoRA/FSDP wrapping, so wan2.2's two transformers both get it.