finer-tuned handling of ambiguous XML nodes for infix operators #2115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2115 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 120 120
Lines 5242 5231 -11
==========================================
- Hits 5224 5213 -11
Misses 18 18
|
AshesITR
reviewed
Sep 7, 2023
AshesITR
reviewed
Sep 8, 2023
R/undesirable_operator_linter.R
Outdated
| needs_exact_string <- !is.na(undesirable_operator_metadata$exact_string_value[included_operators]) | ||
| needs_exact_string <- operator_nodes %in% infix_metadata$xml_tag[infix_metadata$ambiguous_node] | ||
| operator_nodes[needs_exact_string] <- sprintf( | ||
| "%s[text() = '%s']", |
Collaborator
There was a problem hiding this comment.
This snippet could be refactored into infix_metadata (xml_token?) to avoid duplication.
Collaborator
Author
|
FWIW this does not affect anyone on GitHub: |
AshesITR
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1977. This is sort of a breaking change, though it doesn't affect any defaults, but I think the new behavior is much cleaner.