code formatting#20
Merged
Merged
Conversation
Member
|
I'm ok with the result. It hurts the readability of the If it synthesizes, that should be enough. |
Contributor
Author
|
I checked and it synthesizes fine. I'll merge the PR then ok? |
Member
|
Ah. Could you compare the verilog of with and without this patch? It should be exactly equal. If yes, this is good to merge. |
Contributor
Author
|
Checked with git diff and its exactly equal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simply ran black on all the files. Not tested if it still runs/synthesizes as before but probably should?