Add tests for MatrixGate over 6 qubits#1041
Merged
mhucka merged 3 commits intoquantumlib:mainfrom Apr 7, 2026
Merged
Conversation
Verifiy that `_translate_MatrixGate` and `QSimSimulator.compute_amplitudes` raise `NotImplementedError` when provided a 7-qubit `MatrixGate`.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new test cases to verify that qsimcirq correctly raises a NotImplementedError when encountering MatrixGate objects exceeding the 6-qubit limit. The review feedback identifies a potential AttributeError from direct submodule access and a naming convention violation where the variable qsimSim should be renamed to qsim_sim to comply with the project's snake_case style guide.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifiy that
_translate_MatrixGateandQSimSimulator.compute_amplitudesraiseNotImplementedErrorwhen provided a 7-qubitMatrixGate.