Skip to content

Re-enable sid container rebuild in CI - #44

Open
Simon Beaudoin (simonbeaudoin0935) wants to merge 4 commits into
mainfrom
fix/re-enable-sid-container-build
Open

Re-enable sid container rebuild in CI#44
Simon Beaudoin (simonbeaudoin0935) wants to merge 4 commits into
mainfrom
fix/re-enable-sid-container-build

Conversation

@simonbeaudoin0935

Copy link
Copy Markdown
Contributor

Summary

  • remove temporary distro-skip logic in docker_deb_build.py rebuild mode
  • restore sid in the Debian image validation loop of container-build-and-upload.yml
  • restore sid push in the Debian image upload list

Validation

  • python3 -m py_compile docker_deb_build.py create_data_tar.py docker_rpm_build.py
  • python3 docker_deb_build.py --help

Context

This reverts the temporary sid exclusion introduced in PR #42 and removes the
rebuild skip-list so all discovered distros are evaluated during rebuild.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Remove temporary rebuild skip logic so rebuild mode checks
all discovered Debian and Ubuntu Dockerfiles again.

Restore sid in the container workflow's dummy-package
validation loop and Debian image push list.

Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Align rebuild-all behavior with the supported distro set already
exposed through --distro choices.

This keeps temporary skip-list logic removed while preventing
unsupported suites like questing from breaking the sweep.

Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Add Debian forky as a supported suite in docker_deb_build,
container workflow validation, and docker image upload paths.

Introduce sid best-effort handling in container-build-and-upload:
if sid image build or validation fails, continue the run and skip
sid push while keeping other suites blocking.

Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Forky currently does not expose the gh package in default apt
metadata.

Guard the package install step to drop gh when unavailable so the
forky image can still build with the remaining base tooling.

Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants