FIX: debug-mode and logging bugs in #337#354
Merged
Merged
Conversation
kernprof.py
_gather_preimport_targets()
Fixed typo (`diagnostics.log.warn` -> `diagnostics.log.warning`)
_format_call_message()
- Added handling for `functools.partial`
- Added fallback handling for arbitrary callable
tests/test_kernprof.py
test_bad_prof_mod_target()
Test triggering the warning in `_gather_preimport_targets()`
test_call_with_diagnostics()
Test the various forms in which `_call_with_diagnostics()` is
used
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 69.14% 69.82% +0.68%
==========================================
Files 18 18
Lines 1614 1614
Branches 344 344
==========================================
+ Hits 1116 1127 +11
+ Misses 420 410 -10
+ Partials 78 77 -1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
LGTM, great work as always. I really appreciate the time and effort you are putting into this project. You're making software better for a lot of people. I think we are close to getting all of the PRs merged and making a significant 4.3 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
kernprof.py_gather_preimport_targets():Fixed typo (
diagnostics.log.warn->diagnostics.log.warning)_format_call_message():functools.partialtests/test_kernprof.pytest_bad_prof_mod_target():New test triggering the warning in
_gather_preimport_targets()test_call_with_diagnostics():New test for the various forms in which
_call_with_diagnostics()is used