Skip to content

Conversation

@zpcore
Copy link
Member

@zpcore zpcore commented Apr 4, 2025

No description provided.

@tengyifei tengyifei force-pushed the piz/2.6.1-trigger branch from c4a416a to 17abdbe Compare April 4, 2025 19:01
@zpcore zpcore marked this pull request as ready for review April 4, 2025 22:58
@zpcore zpcore requested review from ManfeiBai and lsy323 as code owners April 4, 2025 22:58
@zpcore zpcore requested a review from tengyifei April 4, 2025 22:58
@zpcore
Copy link
Member Author

zpcore commented Apr 4, 2025

Hmm, the GPU test fails from the HEAD. We have to wait for the GPU fix first.

@tengyifei
Copy link
Collaborator

Hmm, the GPU test fails from the HEAD. We have to wait for the GPU fix first.

There are no GPU wheels for 2.6 and in any case, the GPU tests are not required to pass to merge a PR because they break too much rn.

@zpcore
Copy link
Member Author

zpcore commented Apr 4, 2025

Hmm, the GPU test fails from the HEAD. We have to wait for the GPU fix first.

There are no GPU wheels for 2.6 and in any case, the GPU tests are not required to pass to merge a PR because they break too much rn.

Yes, I think it doesn't matter. The block is due to missing the review from code owner.

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@zpcore zpcore merged commit 379ebd5 into master Apr 4, 2025
21 of 24 checks passed
@ManfeiBai
Copy link
Collaborator

would you mind update the description too?

@zpcore zpcore deleted the piz/2.6.1-trigger branch April 4, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants