Skip to content

Conversation

@zpcore
Copy link
Member

@zpcore zpcore commented Apr 2, 2025

No description provided.

@zpcore zpcore marked this pull request as ready for review April 2, 2025 22:52
@zpcore zpcore requested review from ManfeiBai and tengyifei April 2, 2025 22:53
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Copy link
Collaborator

@tengyifei tengyifei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the build failed because some code is still referencing the removed API

@zpcore zpcore merged commit f1fe8bc into master Apr 3, 2025
22 of 23 checks passed
@zpcore zpcore deleted the piz/deprecate branch April 3, 2025 05:12
@zpcore
Copy link
Member Author

zpcore commented Apr 3, 2025

I think the build failed because some code is still referencing the removed API

Yes, fixed. Now the CI failure is irrelevant to the PR.

zpcore added a commit that referenced this pull request Apr 4, 2025
zpcore added a commit that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants