Skip to content

Conversation

@will-cromar
Copy link
Collaborator

Otherwise we get this error:

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: libtpu-nightly@                          
         https://storage.googleapis.com/cloud-tpu-tpuvm-artifacts/wheels/libtpu-
         nightly/libtpu_nightly-0.1.dev20240612-py3-none-any.whl ; extra ==     
         "tpuvm". See https://packaging.python.org/specifications/core-metadata 
         for more information. 

Otherwise we get this error:

```
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: libtpu-nightly@                          
         https://storage.googleapis.com/cloud-tpu-tpuvm-artifacts/wheels/libtpu-
         nightly/libtpu_nightly-0.1.dev20240612-py3-none-any.whl ; extra ==     
         "tpuvm". See https://packaging.python.org/specifications/core-metadata 
         for more information. 
```
@will-cromar will-cromar requested review from JackCaoG and bhavya01 July 24, 2024 22:33
@will-cromar
Copy link
Collaborator Author

@JackCaoG what do you think of just removing this dep on master too? We'll have to update any tests/usage that uses torch_xla[tpuvm] to use torch_xla[tpu] -f ...

@will-cromar will-cromar merged commit 813ffe5 into r2.4 Jul 24, 2024
@JackCaoG
Copy link
Collaborator

I forgot why we switched to tpu from tpuvm but if this is the future direction we should just deprecate old usage.. only thing I am not sure if can we add some warning messages when users run with [tpuvm]

@will-cromar
Copy link
Collaborator Author

PyPI rejecting the tpuvm form (direct dependency on HTTP URL) is the reason we added tpu instead. FWIW, tpuvm has not been in stable releases since 2.1.0 for exactly this reason. This would only affect us and potentially any users of the nightly package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants