Skip to content

Conversation

@JackCaoG
Copy link
Collaborator

User should downcast their model directly or use amp.

Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JackCaoG JackCaoG merged commit af51f06 into master May 30, 2024
@JackCaoG JackCaoG deleted the JackCaoG/warning_message_XLA_USE_BF16 branch May 30, 2024 04:17
@will-cromar
Copy link
Collaborator

Thanks! I'm glad to see this being removed.

@miladm
Copy link
Collaborator

miladm commented May 30, 2024

Can we also remove this line from the repo @JackCaoG?
https://github.com/pytorch/xla/blob/master/configuration.yaml#L125

@JackCaoG
Copy link
Collaborator Author

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants