[Fori_loop|While_loop] Placeholder lower torch.while_loop with python dispatch for simple addition test case #6532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f35899a to
122d6e5
Compare
Collaborator
Author
|
CI failed due to |
mbzomowski
reviewed
Feb 20, 2024
Collaborator
mbzomowski
left a comment
There was a problem hiding this comment.
LGTM for the TPU CI portion: https://github.com/pytorch/xla/actions/runs/7980785965/job/21791172250
But I'll leave it to pt/xla folks to approve.
qihqi
approved these changes
Feb 21, 2024
yeounoh
reviewed
Feb 22, 2024
yeounoh
reviewed
Feb 22, 2024
| from torch._higher_order_ops.while_loop import while_loop_op | ||
|
|
||
|
|
||
| @while_loop_op.py_impl(DispatchKey.XLA) |
Contributor
There was a problem hiding this comment.
Great to see that this is working!
yeounoh
reviewed
Feb 22, 2024
yeounoh
approved these changes
Feb 22, 2024
Contributor
yeounoh
left a comment
There was a problem hiding this comment.
LGTM, left some minor comments.
4 tasks
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
… dispatch for simple addition test case (pytorch#6532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the step one PR:
Due to
torch.while_loopis defined in torch/_higher_order_ops/while_loop.py, not described in native_functions.yaml, lowertorch.while_loopvia python dispatch like PR#5763TODO: current status need to patch thepython dispatchin PyTorch code, we need modify this PR to enable the python dispatch from PyTorch/XLA codechild PR: #6529
PR resource: #6527