[FSDPv2] Add a user guide #6386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds a user guide for FSDPv2.
Collaborator
|
Can you also update https://github.com/pytorch/xla/blob/master/docs/source/index.rst so it will show up in https://pytorch.org/xla/release/2.1/index.html? |
JackCaoG
reviewed
Jan 26, 2024
jonb377
reviewed
Jan 26, 2024
| # As normal FSDP, but an extra mesh is needed. | ||
| model = FSDPv2(my_module, mesh) | ||
| optim = torch.optim.Adam(model.parameters(), lr=0.0001) | ||
| output = model(x, y) |
Collaborator
There was a problem hiding this comment.
We'll need to add input sharding here - do you want to add an example with MpDeviceLoader?
Collaborator
Author
There was a problem hiding this comment.
Let's manually shard the x here. Good catch!
JackCaoG
approved these changes
Jan 29, 2024
Collaborator
Author
|
Thanks, @JackCaoG! |
alanwaketan
added a commit
that referenced
this pull request
Jan 29, 2024
Summary: This diff adds a user guide for FSDPv2.
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: This diff adds a user guide for FSDPv2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a user guide for FSDPv2.