Std mean #3004
Merged
Std mean #3004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
requested changes
Jun 25, 2021
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
Mostly LGTM, minor nits. Please fix the format too.
torch_xla/csrc/ops/std_mean.cpp
Outdated
Comment on lines
14
to
25
| xla::XlaOp LowerStd(xla::XlaOp input, | ||
| const std::vector<xla::int64>& dimensions, | ||
| bool keep_reduced_dimensions, | ||
| xla::int64 correction) { | ||
| return BuildStdDeviation(input, dimensions, keep_reduced_dimensions, correction); | ||
| } | ||
|
|
||
| xla::XlaOp LowerMean(xla::XlaOp input, | ||
| const std::vector<xla::int64>& dimensions, | ||
| bool keep_reduced_dimensions) { | ||
| return BuildMean(input, dimensions, keep_reduced_dimensions); | ||
| } |
Collaborator
There was a problem hiding this comment.
You don't really need these two helper function if they are just forwarding argument to BuildStdDeviation and BuildMean. You only replace the use of these two function with Buildxxx directly.
torch_xla/csrc/ops/std_mean.cpp
Outdated
| bool keep_reduced_dimensions, | ||
| xla::int64 correction) { | ||
| auto lower_for_shape_fn_std_mean = [&](absl::Span<const xla::XlaOp> operands) -> xla::XlaOp { | ||
| auto std = LowerStd(operands[0], dimensions, keep_reduced_dimensions, correction); |
Collaborator
There was a problem hiding this comment.
Let's try not to use auto when we can 😄 , I think in general we only use it when the type name is super long and complicated. In this case we can just use xla::XlaOp.
torch_xla/csrc/ops/std_mean.cpp
Outdated
| xla::int64 correction) { | ||
| auto lower_for_shape_fn_std_mean = [&](absl::Span<const xla::XlaOp> operands) -> xla::XlaOp { | ||
| auto std = LowerStd(operands[0], dimensions, keep_reduced_dimensions, correction); | ||
| auto mean = LowerMean(operands[0], dimensions, keep_reduced_dimensions); |
JackCaoG
approved these changes
Jun 28, 2021
Comment on lines
+1313
to
+1314
| ExpectCounterNotChanged("aten::.*", cpp_test::GetIgnoredCounters()); | ||
| ExpectCounterChanged("xla::std_mean", cpp_test::GetIgnoredCounters()); |
Collaborator
There was a problem hiding this comment.
NIT, move this two check our of the for loop. We only need to check once at the end of the test, instead of for every execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR draft for std_mean.
The PR is to be tested.
Issue link