Skip to content

Update ET pin for #6744#140199

Closed
huydhn wants to merge 4 commits intopytorch:mainfrom
huydhn:clean-executorch-before-build
Closed

Update ET pin for #6744#140199
huydhn wants to merge 4 commits intopytorch:mainfrom
huydhn:clean-executorch-before-build

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Nov 9, 2024 •
edited
Loading

This will be updated to ET trunk commit after pytorch/executorch#6744 lands. I also move ET back from unstable and install llama3 dependencies

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140199

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 081b862 with merge base 09ba38c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn changed the title CLeanup ExecuTorch checkout dir before building Cleanup ExecuTorch checkout dir before building Nov 9, 2024
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Nov 9, 2024

@pytorchbot drci

@huydhn huydhn added the no-runner-experiments Bypass Meta/LF runner determinator label Nov 9, 2024
@huydhn huydhn changed the title Cleanup ExecuTorch checkout dir before building Update ET pin for #6744 Nov 9, 2024
@huydhn huydhn requested a review from larryliu0820 November 9, 2024 03:14
@huydhn huydhn marked this pull request as ready for review November 9, 2024 03:14
@huydhn huydhn requested review from a team and jeffdaily as code owners November 9, 2024 03:14
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Nov 9, 2024

Going to test this out on #140199 to wait for a green CI signal before landing. I have been able to verified this locally

@huydhn huydhn mentioned this pull request Nov 9, 2024
Merged
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Nov 11, 2024

@larryliu0820 Please help take a look, this will finally put ET back to PT CI

@huydhn huydhn requested a review from kit1980 November 11, 2024 21:25
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Nov 11, 2024

@pytorchbot merge -f 'ET job has passed'

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 11, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Nov 12, 2024 •
edited
Loading

Plz don't revert this one yet as I think it has a landrace with #136598. As that commit has been reverted in https://hud.pytorch.org/pytorch/pytorch/commit/222175b3d59f54e02c67db7d4a8ff3c4c69fb45f, let's see if it fix the failure from this PR

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@huydhn
Update ET pin for pytorch#6744 (pytorch#140199)
1f5d547 
This will be updated to ET trunk commit after pytorch/executorch#6744 lands.  I also move ET back from unstable and install llama3 dependencies
Pull Request resolved: pytorch#140199
Approved by: https://github.com/kit1980
@huydhn huydhn deleted the clean-executorch-before-build branch January 16, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor Merged no-runner-experiments Bypass Meta/LF runner determinator test-config/default test-config/executorch topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huydhn @pytorchmergebot @kit1980