Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9773
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a8032e3 with merge base 97bca05 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
9b3a2fc to
764c941
Compare
larryliu0820
approved these changes
Mar 31, 2025
764c941 to
51a5225
Compare
51a5225 to
a8032e3
Compare
mergennachin
approved these changes
Mar 31, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
### Summary We pretty much always include xnnpack when building wheels, so why not just turn it on by default? If users want it off, they can opt-out.  ### Test plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We pretty much always include xnnpack when building wheels, so why not just turn it on by default? If users want it off, they can opt-out.
Test plan
CI