Migrate java api: LlamaModule -> LlmModule#9478

Merged

facebook-github-bot merged 10 commits intomainfrom

migrate-java-api

Mar 21, 2025

Contributor

kirklandsign commented Mar 20, 2025

No description provided.

kirklandsign added 4 commits

March 20, 2025 16:02


          Initial commit

6b615bd

Next step: rename other llama to llm


          Try to migrate Android Llm part to its own package

dc789c3

Fix

3d1130a

Fix

935c2ad

pytorch-bot bot commented Mar 20, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9478

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 2e9ae2b with merge base 079e54e ():

NEW FAILURES - The following jobs have failed:

android-perf / benchmark-on-device (ic3, qnn_q8, samsung_galaxy_s22, arn:aws:devicefarm:us-west-2:308535385114:d... / mobile-job (android) (gh)
curl: (22) The requested URL returned error:
android-perf / export-models (ic3, qnn_q8, samsung_galaxy_s22, arn:aws:devicefarm:us-west-2:308535385114:devicep... / linux-job (gh)
RuntimeError: Command docker exec -t 6cc56402260ddb2ea556d80f1553081552cc826a361396b4f2601d2f1bb325e8 /exec failed with exit code 1
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 3

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

kirklandsign added the release notes: api label


          annotation

579b13e

kirklandsign marked this pull request as ready for review

March 20, 2025 23:34

kirklandsign requested review from cmodi-meta, larryliu0820 and lucylq and removed request for larryliu0820

March 20, 2025 23:34

Contributor

facebook-github-bot commented Mar 20, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update BUCK

6fcf073

Contributor

facebook-github-bot commented Mar 20, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          update path

3884aa7

Contributor

facebook-github-bot commented Mar 20, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          fix buck

e01839c

Contributor

facebook-github-bot commented Mar 20, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kirklandsign added 2 commits

March 20, 2025 17:45

Fix


          lint

2e9ae2b

Contributor

facebook-github-bot commented Mar 21, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820 approved these changes

View reviewed changes

Contributor

larryliu0820 left a comment

LGTM

kirklandsign temporarily deployed to upload-benchmark-results

March 21, 2025 04:51

— with

GitHub Actions Inactive

facebook-github-bot merged commit a6cd1dc into main

87 of 91 checks passed

facebook-github-bot deleted the migrate-java-api branch

March 21, 2025 07:43

mergennachin reviewed

View reviewed changes

extension/android/src/main/java/org/pytorch/executorch/LlamaCallback.java

    
               * <p>Note: deprecated! Please use {@link org.pytorch.executorch.extension.llm.LlmCallback} instead.

               */

              @Experimental

              @Deprecated

Contributor

mergennachin Mar 21, 2025

Since this was already tagged as experimental to begin with, we should just delete this altogether with 0.6 release. We don't need to keep for two releases, like we do with stable APIs.

https://pytorch.org/executorch/main/api-life-cycle.html#api-life-cycle

DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request


          Migrate java api

b334598

Differential Revision: D71588845

Pull Request resolved: pytorch#9478

kirklandsign changed the title ~~Migrate java api~~ Migrate java api: LlamaModule -> LlmModule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed release notes: api