Use -fsanitize=address,undefined in debug builds on CI

[swolchok]

These sanitizers help catch bugs. AIUI, they only affect a few unittest jobs.

[swolchok]

Stack from ghstack (oldest at bottom):

• -> Use -fsanitize=address,undefined in debug builds on CI #9397

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9397

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 75d3886 with merge base 01a22b6 ():

NEW FAILURES - The following jobs have failed:

• Check Labels / Check labels (gh)
  RuntimeError: Error checking labels: PR does not have required labels
• trunk / unittest-release / linux / linux-job (gh)
  backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d_batchnorm_seq

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

• trunk / test-arm-backend-delegation / linux-job (gh) (#9399)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[mergennachin]

Great idea. On top of asan and ubsan, it'd be great to have tsan too, especially with thread pool enabled.

But you can't enable all three at the same time. You might have to have a dedicated tsan job version (with thread pool enabled) for the unittest.

[mergennachin]

Don't you want CXXFLAGS="-fsanitize=address,undefined -g"?

[swolchok]

if I'm not mistaken, CXXFLAGS merely adds to the flags. I will check.

[swolchok]

I checked and -g is still present (and there appear to be no other optimization/debug flags added in CMAKE_BUILD_TYPE=Debug)

[swolchok]

it'd be great to have tsan too,

that one needs to go on the backlog, I haven't got time right now and I suspect we have extant-but-benign TSAN problems

[swolchok]

unittest-release failure is a known flake. test-arm-backend-delegation has been having problems lately and is unlikely to be unlikely broken by this change. merging.