Make BroadcastIndexesRange efficient if there is no broadcasting#9298
Merged
Make BroadcastIndexesRange efficient if there is no broadcasting#9298
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9298
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 18, 2025
manuelcandales
approved these changes
Mar 18, 2025
Contributor
Author
|
noting CI is green before rebasing due to spurious conflicts before land |
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…orch#9298) It seems to be OK to just check for broadcasting when creating the iterator and then leave a highly-predictable branch inside the loop. Avoids code near-duplication to handle both broadcast and non-broadcast cases.
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…orch#9298) It seems to be OK to just check for broadcasting when creating the iterator and then leave a highly-predictable branch inside the loop. Avoids code near-duplication to handle both broadcast and non-broadcast cases.
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
It seems to be OK to just check for broadcasting when creating the iterator and then leave a highly-predictable branch inside the loop. Avoids code near-duplication to handle both broadcast and non-broadcast cases. ghstack-source-id: 8be7c18 ghstack-comment-id: 2725945271 Pull Request resolved: pytorch/executorch#9298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to be OK to just check for broadcasting when creating the
iterator and then leave a highly-predictable branch inside the
loop. Avoids code near-duplication to handle both broadcast and
non-broadcast cases.