Support MPS Backend also on iOS < 16 (#9089) by f-meloni · Pull Request #9095 · pytorch/executorch

f-meloni · 2025-03-10T18:09:29Z

Summary: Pull Request resolved: #9089

Differential Revision: D70795041

The MPS backend currently does not compile for iOS < 16.
I have added some conditional code to make it usable anyway

pytorch-bot · 2025-03-10T18:09:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9095

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5421a77 with merge base 4c54bab ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

f-meloni · 2025-03-10T18:12:51Z

cc @DenisVieriu97

f-meloni · 2025-03-10T18:13:07Z

@pytorchbot label "topic: not user facing"

facebook-github-bot · 2025-03-10T18:14:12Z

This pull request was exported from Phabricator. Differential Revision: D70795041

facebook-github-bot · 2025-03-10T18:14:20Z

This pull request was exported from Phabricator. Differential Revision: D70795041

shoumikhin · 2025-03-15T01:32:48Z

@DenisVieriu97 please take a look!

shoumikhin · 2025-03-17T02:25:28Z

@DenisVieriu97 shall we just merge it?

cccclai · 2025-03-18T02:20:58Z

backends/apple/mps/runtime/operations/IndexingOps.mm

-    Debug, "%s %d: %d",
-    __FUNCTION__, graphNode->input1_id(), graphNode->output_id()
-  );
+  if (@available(iOS 16, macOS 13, *)) {


Should we return an error for the else statement

If the if is not true, then we do not do _idToMPSGraphTensor[graphNode->output_id()] = ... which I think would then not set the tensor value and that would fail the prediction, but only if this is used.
Do you think we should return Error::notSupported or something like that?

Yeah, just we can handle it in a non-fatal way.

@cccclai Is the latest version OK?
Thank you for the review :)

Summary: Differential Revision: D70795041

facebook-github-bot · 2025-03-18T23:37:51Z

This pull request was exported from Phabricator. Differential Revision: D70795041

facebook-github-bot · 2025-03-18T23:40:31Z

This pull request was exported from Phabricator. Differential Revision: D70795041

Summary: Pull Request resolved: pytorch#9095 Pull Request resolved: pytorch#9089 Differential Revision: D70795041

cccclai · 2025-03-19T04:29:30Z

backends/apple/mps/runtime/operations/IndexingOps.mm

+
+    return Error::Ok;
+  } else {
+    return Error::NotSupported;


Thanks, one minor thing - can you add an error log here like

ET_LOG(Error, "...")

Added, and I also changed the requirements to iOS 15.4 and MacOS 12.3

Summary: Reviewed By: cccclai Differential Revision: D70795041

facebook-github-bot · 2025-03-19T15:59:21Z

This pull request was exported from Phabricator. Differential Revision: D70795041

Summary: Pull Request resolved: pytorch#9095 Pull Request resolved: pytorch#9089 Reviewed By: cccclai Differential Revision: D70795041

facebook-github-bot · 2025-03-19T16:03:08Z

This pull request was exported from Phabricator. Differential Revision: D70795041

DenisVieriu97

Looks good - thanks @f-meloni for the changes

DenisVieriu97 · 2025-03-19T16:13:36Z

backends/apple/mps/runtime/MPSDevice.mm

-#if defined(__MAC_13_0)
-  if (macOS13Plus) {
-    languageVersion = MTLLanguageVersion3_0;
+  if (@available(iOS 16, macOS 13, *)) {


Thank you for the change

DenisVieriu97 · 2025-03-19T16:14:04Z

backends/apple/mps/runtime/operations/IndexingOps.mm

-    Debug, "%s %d: %d",
-    __FUNCTION__, graphNode->input1_id(), graphNode->output_id()
-  );
+  if (@available(iOS 15.4, macOS 12.3, *)) {


Differential Revision: D70795041 Pull Request resolved: pytorch#9095

f-meloni requested a review from cccclai as a code owner March 10, 2025 18:09

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2025

f-meloni changed the title ~~Add MPS Backend (#9089)~~ Support MPS Backend also on iOS < 16 (#9089) Mar 10, 2025

pytorch-bot bot added the topic: not user facing label Mar 10, 2025

cccclai requested a review from DenisVieriu97 March 10, 2025 18:13

facebook-github-bot added the fb-exported label Mar 10, 2025

f-meloni force-pushed the export-D70795041 branch from cd9846d to 53a893c Compare March 10, 2025 18:14

cccclai reviewed Mar 18, 2025

View reviewed changes

f-meloni force-pushed the export-D70795041 branch from 53a893c to c09c4ac Compare March 18, 2025 23:37

f-meloni pushed a commit to f-meloni/executorch that referenced this pull request Mar 18, 2025

Add MPS Backend (pytorch#9095)

675934a

Summary: Differential Revision: D70795041

f-meloni force-pushed the export-D70795041 branch from c09c4ac to 675934a Compare March 18, 2025 23:37

f-meloni pushed a commit to f-meloni/executorch that referenced this pull request Mar 18, 2025

Add MPS Backend (pytorch#9095)

c09c4ac

Summary: Differential Revision: D70795041

f-meloni pushed a commit to f-meloni/executorch that referenced this pull request Mar 18, 2025

Add MPS Backend (pytorch#9095)

09267c4

Summary: Pull Request resolved: pytorch#9095 Pull Request resolved: pytorch#9089 Differential Revision: D70795041

f-meloni force-pushed the export-D70795041 branch from 675934a to 09267c4 Compare March 18, 2025 23:40

cccclai approved these changes Mar 19, 2025

View reviewed changes

f-meloni pushed a commit to f-meloni/executorch that referenced this pull request Mar 19, 2025

Add MPS Backend (pytorch#9095)

02d0646

Summary: Reviewed By: cccclai Differential Revision: D70795041

f-meloni force-pushed the export-D70795041 branch from 09267c4 to 02d0646 Compare March 19, 2025 15:59

f-meloni pushed a commit to f-meloni/executorch that referenced this pull request Mar 19, 2025

Add MPS Backend (pytorch#9095)

c1b1109

Summary: Reviewed By: cccclai Differential Revision: D70795041

f-meloni force-pushed the export-D70795041 branch from 02d0646 to c1b1109 Compare March 19, 2025 15:59

Add MPS Backend (pytorch#9095)

5421a77

Summary: Pull Request resolved: pytorch#9095 Pull Request resolved: pytorch#9089 Reviewed By: cccclai Differential Revision: D70795041

f-meloni force-pushed the export-D70795041 branch from c1b1109 to 5421a77 Compare March 19, 2025 16:03

DenisVieriu97 approved these changes Mar 19, 2025

View reviewed changes

facebook-github-bot merged commit a699b5b into pytorch:main Mar 19, 2025
89 checks passed

oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025

Support MPS Backend also on iOS < 16 (pytorch#9089)

e607ad9

Differential Revision: D70795041 Pull Request resolved: pytorch#9095

DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025

Support MPS Backend also on iOS < 16 (pytorch#9089)

b81e7f2

Differential Revision: D70795041 Pull Request resolved: pytorch#9095

Conversation

f-meloni commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9095

✅ No Failures

Uh oh!

f-meloni commented Mar 10, 2025

Uh oh!

f-meloni commented Mar 10, 2025

Uh oh!

facebook-github-bot commented Mar 10, 2025

Uh oh!

facebook-github-bot commented Mar 10, 2025

Uh oh!

shoumikhin commented Mar 15, 2025

Uh oh!

shoumikhin commented Mar 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 18, 2025

Uh oh!

facebook-github-bot commented Mar 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 19, 2025

Uh oh!

facebook-github-bot commented Mar 19, 2025

Uh oh!

DenisVieriu97 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

f-meloni commented Mar 10, 2025 •

edited

Loading

pytorch-bot bot commented Mar 10, 2025 •

edited

Loading