Replace custom optional with std::optional#9068
Conversation
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9068
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
ping reviewer @JacobSzwejbka |
JacobSzwejbka
left a comment
There was a problem hiding this comment.
Hmm I feel like I've been asked by like 4 different people about removing this, I guess none of them ever put up a PR. Thanks for doing it
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
We have C++17, no reason to keep this old thing around. Had to resolve some ambiguous overloads.